Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault upgrade #93

Merged
merged 2 commits into from
Apr 17, 2024
Merged

vault upgrade #93

merged 2 commits into from
Apr 17, 2024

Conversation

austinFlipside
Copy link
Member

  • uses vault secret for Github UDFs

juls858
juls858 requested changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@juls858 juls858 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secret should be dynamic as these are also used by data studio users. Secret name should depend on who is making the call. Something like this:

IFF(_uttils.udf_whoami() <> CURRENT_USER(), '_FSC_SYS/GITHUB', 'VAULT/...')

@austinFlipside austinFlipside requested a review from juls858 April 17, 2024 20:06
@austinFlipside austinFlipside merged commit 554550f into main Apr 17, 2024
2 checks passed
@austinFlipside austinFlipside deleted the AN-4759/upgrade-github-utils-to-vault branch April 17, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juls858 juls858 juls858 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinFlipside @juls858