Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update favicon to flexmeasures logo #889

Closed
wants to merge 28 commits into from

Conversation

GustaafL
Copy link
Contributor

@GustaafL GustaafL commented Nov 3, 2023

Description

Uses FlexMeasures logo as favicon

Look & Feel

Any page of FlexMeasures shows the favicon tab of the browser

How to test

Start FlexMeasures server and navigate to a FlexMeasures page

Further Improvements

Potential improvements to be done in the same PR or follow up Issues/Discussions/PRs.


  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

GustaafL added 28 commits October 12, 2023 12:39
Signed-off-by: GustaafL <[email protected]>
Signed-off-by: GustaafL <[email protected]>
@GustaafL GustaafL changed the base branch from main to feature/add-consultancy-account November 3, 2023 11:30
@nhoening
Copy link
Contributor

nhoening commented Nov 3, 2023

The base branch should be main, not feature/add-consultancy-account.

@Flix6x
Copy link
Contributor

Flix6x commented Nov 3, 2023

The base branch should be main, not feature/add-consultancy-account.

My advice for handling that would be to do nothing for now. If you just hold off with merging until after that feature branch has been merged, the base branch for the PR automatically updates to main and your git problem should resolve itself.

Base automatically changed from feature/add-consultancy-account to main November 3, 2023 20:38
@GustaafL GustaafL closed this Nov 8, 2023
@GustaafL GustaafL deleted the feature/update-favicon-to-flexmeasures-logo branch November 8, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants