-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: benchmark util for assessing performance #787
Conversation
Signed-off-by: Nischay Ram Mamidi <[email protected]>
Signed-off-by: Nischay Ram Mamidi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and it works fine. Thanks!
Could you round the measured duration to a shorter representation (e.g. 2 after-comma digits)?
Maybe @Flix6x has ideas for the commands:
- Under which circumstances do these work? (I believe this assumes our production db dump)?
- Could we maintain the list of sensors outside of the main code, or above in a handy-to-edit list?
- What other commands would be useful, e.g.
add schedule for-storage
|
I would like it if the sensor ID (for me, one is enough) could be passed when calling the benchmark script, so the script can be used on any FlexMeasures database. For me, it would then make sense to also allow passing a custom start, duration and max_iterations (possibly with the current values as defaults). I do like the benchmark showing results for several durations, but a single sensor is all I need. |
Signed-off-by: F.N. Claessen <[email protected]>
…mmand, as well Signed-off-by: Nicolas Höning <[email protected]>
Signed-off-by: Nicolas Höning <[email protected]>
Signed-off-by: Nicolas Höning <[email protected]>
Signed-off-by: Nicolas Höning <[email protected]>
Signed-off-by: Nicolas Höning <[email protected]>
Signed-off-by: Nicolas Höning <[email protected]>
@Flix6x I don't agree this PR was ready. Let's re-open it. It should not call the CLI as that takes too long by itself. I have not found the best way to benchmark otherwise yet. Maybe API or CLI or calling into functions directly. But as you in one of my commits, the client is not a good way either IMO. |
This reverts commit 82949bf. Signed-off-by: F.N. Claessen <[email protected]>
Apologies. I reverted the merge commit on the main branch: 8ed96e1. |
How can we re-open a PR? |
Oh I see #949 is the new one for this. |
Description
This PR adds a new benchmarking script to quickly check the performance of flexmeasures and allows the devs to check the performance of the code.
To use, simply have flexmeasures configured and activated in your local environment, and run
located in the
ci
folder of the root directory.