Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid custom UI error #45

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Avoid custom UI error #45

merged 1 commit into from
Dec 18, 2024

Conversation

HashidaTKS
Copy link
Contributor

This is a cherry-pick of #44 for the master branch.

Avoid custom UI error like below.

image

The "TabMail" tab exists only in the ribbon whose id is "Microsoft.Outlook.Explorer". So if we open a ribbon whose id is not "Microsoft.Outlook.Explorer", we may get a custom UI error like "TabMail" doesn't exist. The error is displayed when Outlook's setting "Options" -> "Advanced" -> "Show add-in user interface errors" ("オプション" -> "詳細設定" -> "アドイン ユーザー インターフェイスのエラーを表示する" in Japanese) is enabled.

This patch avoid that error by creating custom UI only when ribbonID is "Microsoft.Outlook.Explorer".

Test

  • Install (enable) FlexConfirmMail
  • Open Outlook option
  • Enable "Options" -> "Advanced" -> "Show add-in user interface errors" ("オプション" -> "詳細設定" -> "アドイン ユーザー インターフェイスのエラーを表示する") of Outlook
  • Open Home tab
    • Confirm that FlexConfirmMail icon is displayed
  • Double clock a mail to popup new inspector
    • Confirm that the dialog for "Custom UI runtime error" is not displayed

The "TabMail" tab exists only in the ribbon whose id is "Microsoft.Outlook.Explorer". So if we open a ribbon
whose id is not "Microsoft.Outlook.Explorer", we may get a custom UI error like "TabMail" doesn't exist.
The error is displayed when Outlook's setting "Options" -> "Advanced" -> "Show add-in user interface errors"
is enabled.

This patch avoid that error by creating custom UI only when ribbonID is "Microsoft.Outlook.Explorer".
Copy link
Member

@piroor piroor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@piroor piroor merged commit ec4fc08 into master Dec 18, 2024
1 check passed
@piroor piroor deleted the avoid-custom-ui-error-for-master branch December 18, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants