-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/monorepo cleanup #455
Conversation
WalkthroughThis update focuses on optimizing and refactoring the codebase across various plugins and utilities. Key changes include the adoption of TypeScript's Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
37819b7
to
8beba77
Compare
@coderabbitai review |
@coderabbitai summarize this PR |
Tip For best results, initiate chat on the files or code changes. @carlbrugger, the summary provided in the PR objectives and AI-generated overview offers a comprehensive overview of the changes made in the "Feat/monorepo cleanup" PR. It details the centralization of Rollup configuration, optimization of import statements, replacement of |
405fa13
to
83357c5
Compare
c842b0c
to
7482e51
Compare
2363d98
to
ad569ef
Compare
This is so awesome! And glad that Only feedback is that I don't really like moving the rollup config to a rogue file that's accessed via relative path. |
import { buildConfig } from '../../rollup.config.mjs' vs import { buildConfig } from '@flatfile/rollup-config' |
axios -> cross-fetch
The @flatfile/[email protected] dep uses a NodeJS feature introduced in NodeJS >16
166cb68
to
d93b0ba
Compare
d47eac1
to
5b68f83
Compare
9b6b89f
to
5455e52
Compare
README.md
Outdated
@@ -9,9 +9,9 @@ To get started building plugins: | |||
|
|||
Additional Commands | |||
|
|||
There are more commands that you can run on every plugin at the root level. For instance, the release is run by Github so you don't have to do this manually. | |||
There are more commands that you can run on every plugin at the root level. For instance, the release is run by GitHub so you don't have to do this manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a comma for clarity after "GitHub".
- For instance, the release is run by GitHub so you don't have to do this manually.
+ For instance, the release is run by GitHub, so you don't have to do this manually.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
There are more commands that you can run on every plugin at the root level. For instance, the release is run by GitHub so you don't have to do this manually. | |
There are more commands that you can run on every plugin at the root level. For instance, the release is run by GitHub, so you don't have to do this manually. |
5455e52
to
ce61504
Compare
ce61504
to
285fc7b
Compare
Please explain how to summarize this PR for the Changelog:
axios
withcross-fetch
Tell code reviewer how and what to test:
Summary by CodeRabbit
type
for type-only imports.axios
withfetch
.console.log
for improved test output.Closes: https://github.com/FlatFilers/support-triage/issues/1166