feat: excel extractor column selection #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangarang
approved these changes
Mar 15, 2024
carlbrugger
force-pushed
the
feat/excel-extraction-column-selection
branch
from
1ec5e4d to
7944e98
Compare
carlbrugger
force-pushed
the
feat/excel-extraction-column-selection
branch
from
7944e98 to
7f3eed5
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@flatfile/[email protected], npm/@flatfile/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please explain how to summarize this PR for the Changelog:
This PR fixes column selection when there is a blank header column by removing the column with a blank header rather than the last column.
Tell code reviewer how and what to test:
Extract an Excel file that has an empty header column such as this example:
import_empty_header.xlsx
This PR will produce:
instead of this:
Closes: https://github.com/FlatFilers/support-triage/issues/1094