fix: excel extractor error messaging #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlbrugger
force-pushed
the
fix/excel-extractor-password-protected-error-messaging
branch
from
8048e0b to
adbab5f
Compare
carlbrugger
changed the title
bangarang
approved these changes
Mar 15, 2024
carlbrugger
deleted the
fix/excel-extractor-password-protected-error-messaging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please explain how to summarize this PR for the Changelog:
This PR improves the error messaging for when parsing Excel files.
Tell code reviewer how and what to test:
Upload a password-protected file. Extraction will fail with
File is password-protected. Example file: getting-started-password.xlsxCloses https://github.com/FlatFilers/support-triage/issues/1106