Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache messages #331

Merged
merged 3 commits into from
Nov 28, 2023
Merged

feat: cache messages #331

merged 3 commits into from
Nov 28, 2023

Conversation

carlbrugger
Copy link
Contributor

@carlbrugger carlbrugger commented Nov 22, 2023

This PR caches record messages for comparison against. Currently Platform isn't sending Record messages with the event. This PR work in conjunction with the Platform PR listed below to resolve the issue.

Closes: https://github.com/FlatFilers/support-triage/issues/785
Platform PR: https://github.com/FlatFilers/Platform/pull/5999

@carlbrugger carlbrugger self-assigned this Nov 22, 2023
@carlbrugger carlbrugger marked this pull request as ready for review November 22, 2023 01:55
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @flatfile/[email protected]

Previous url's request limit exceeded
Copy link
Contributor

@ashleygmulligan2 ashleygmulligan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this tie back to an issue? Can you summarize what the problem was. This will help with changelog.

@ashleygmulligan2
Copy link
Contributor

ashleygmulligan2 commented Nov 27, 2023

Platform wasn't sending the record messages to the plugin when there weren't changes, thus old messages weren't being deleted. A platform change was made to enable/fix this, and now the plugin is following. Can you link back to the platform change in your PR description, too?

@carlbrugger carlbrugger merged commit 920df43 into main Nov 28, 2023
4 checks passed
@carlbrugger carlbrugger deleted the feat/record-hook-cache-messages branch November 28, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants