-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to response-rejection plugin #324
Conversation
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concern of this being a breaking change in the utl. Types names have changed. Also, the rejection handler now returns a job response object rather than a total number of rejections as before. This should be a major release. Since the plugin itself isn't impacted in that way, patch seems fine. Tho this is more than a patch/fix, and introduces new functionality, so maybe minor is better here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
if ( | ||
!sheet.config.fields.some((field) => field.key === 'submissionStatus') | ||
) { | ||
await api.sheets.addField(sheet.id, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this field from the sheet when submitting? I'm sure they could strip it out if they wanted but could be nice if it was cleaned up as an option
Guide update: FlatFilers/Guides#955
Kitchen Sink update: FlatFilers/flatfile-docs-kitchen-sink#34
This PR adds better handling of submission status to the
@flatfile/util-response-rejection
plugin by providing webhook with 2 options:- Option 1: Delete all successful records and leave only rejections
- Option 2 (default): Create new (readonly) submission status column that marks each record as "submitted" or "rejected"
Also, the webhook is given the option to set a response message.
Preview video
Future updates:
Example
Clone https://github.com/carlbrugger/bun-webhook
Run:
This will start a webhook server on
localhost:1234
.Paste in
listener.ts
: