Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add field filter & replace sheetId with sheetSlug #218

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

carlbrugger
Copy link
Contributor

@carlbrugger carlbrugger commented Sep 1, 2023

This PR introduces an optional fieldFilter, and enables filtering by either sheetId or sheetSlug.

Example:

listener.use(autocast({ sheetId: 'us_sh_12345678' }))
listener.use(autocast({ sheetSlug: 'foo' }, ['numberField']))
listener.use(autocast({ sheetId: 'us_sh_12345678' }, ['numberField']))
listener.use(autocast({ sheetSlug: 'bar' }, ['numberField', 'dateField']))

@carlbrugger carlbrugger self-assigned this Sep 1, 2023
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @flatfile/[email protected]

@ashleygmulligan2 ashleygmulligan2 self-requested a review September 1, 2023 21:31
Copy link
Contributor

@ashleygmulligan2 ashleygmulligan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do the Guides docs updates at the same time?

@carlbrugger
Copy link
Contributor Author

Can we do the Guides docs updates at the same time?

Sure thing, here it is: FlatFilers/Guides#751

@carlbrugger carlbrugger merged commit 966cf91 into main Sep 1, 2023
3 checks passed
@carlbrugger carlbrugger deleted the feat/autocast-field-filter branch September 1, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants