fix: use system's tmp dir (#223)

FlatFilers · Sep 6, 2023 · 9786771 · 9786771
1 parent 0bd3f75
commit 9786771
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 12 deletions.
diff --git a/.changeset/slimy-deers-attend.md b/.changeset/slimy-deers-attend.md
@@ -0,0 +1,5 @@
+---
+'@flatfile/plugin-zip-extractor': patch
+---
+
+Use system's tmp directory for unzipping
diff --git a/package-lock.json b/package-lock.json
diff --git a/plugins/zip-extractor/package.json b/plugins/zip-extractor/package.json
@@ -30,8 +30,10 @@
     "@flatfile/api": "^1.4.9",
     "@flatfile/hooks": "^1.3.0",
     "@flatfile/listener": "^0.3.15",
-    "@flatfile/util-file-buffer": "0.0.4",
+    "@flatfile/util-common": "^0.1.1",
+    "@flatfile/util-file-buffer": "^0.0.4",
     "adm-zip": "^0.5.10",
+    "os": "^0.1.2",
     "remeda": "^1.14.0"
   },
   "devDependencies": {

diff --git a/plugins/zip-extractor/src/index.ts b/plugins/zip-extractor/src/index.ts
@@ -4,8 +4,14 @@ import api from '@flatfile/api'
 import * as fs from 'fs'
 import path from 'path'
 import AdmZip from 'adm-zip'
+import { tmpdir } from 'os'
+import { logInfo } from '@flatfile/util-common'
 
-export const ZipExtractor = () => {
+export interface PluginOptions {
+  readonly debug?: boolean
+}
+
+export const ZipExtractor = (options: PluginOptions = {}) => {
   return (handler: FlatfileListener) => {
     handler.use(
       fileBuffer('.zip', async (file, buffer, event) => {
@@ -23,6 +29,9 @@ export const ZipExtractor = () => {
             info: 'Unzipping file',
           })
           const zip = new AdmZip(buffer)
+          if (options.debug) {
+            logInfo('@flatfile/plugin-zip-extractor', `tmpdir ${tmpdir()}`)
+          }
           const zipEntries = zip.getEntries()
           await api.jobs.ack(job.data.id, {
             progress: 50,
@@ -34,13 +43,14 @@ export const ZipExtractor = () => {
               !zipEntry.entryName.startsWith('__MACOSX') &&
               !zipEntry.isDirectory
             ) {
-              zip.extractEntryTo(
-                zipEntry,
-                path.join(__dirname, '../'),
-                false,
-                true
-              )
-              const filePath = path.join(__dirname, '../', zipEntry.name)
+              zip.extractEntryTo(zipEntry, tmpdir(), false, true)
+              const filePath = path.join(tmpdir(), zipEntry.name)
+              if (options.debug) {
+                logInfo(
+                  '@flatfile/plugin-zip-extractor',
+                  `filePath ${filePath}`
+                )
+              }
               const stream = fs.createReadStream(filePath)
               await api.files.upload(stream, {
                 spaceId,
@@ -54,7 +64,7 @@ export const ZipExtractor = () => {
             info: 'Extraction complete',
           })
         } catch (e) {
-          console.log(`error ${e}`)
+          logInfo('@flatfile/plugin-zip-extractor', `error ${e}`)
           await api.jobs.fail(job.data.id, {
             info: `Extraction failed ${e.message}`,
           })