fix: bulkRecordHook overwriting messages from recordHook (#235)

* fix: bulkRecordHook overwriting messages from recordHook * Update RecordHook.ts * fix: types --------- Co-authored-by: David Boskovic <[email protected]>
FlatFilers · Sep 19, 2023 · 5ce6306 · 5ce6306
1 parent 6225dba
commit 5ce6306
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/plugins/record-hook/src/RecordHook.ts b/plugins/record-hook/src/RecordHook.ts
@@ -41,27 +41,28 @@ export const BulkRecordHook = async (
   options: { chunkSize?: number; parallel?: number; debug?: boolean } = {}
 ) => {
   try {
-    const records = await event.cache.init<Records>(
+    const batch = await event.cache.init<FlatfileRecords<any>>(
       'records',
-      async () => (await event.data).records
+      async () => {
+        const data = await event.data
+        return prepareXRecords(data.records)
+      }
     )
-    if (!records) return
 
-    const batch = await prepareXRecords(records)
+    if (!batch || batch.records.length === 0) return
 
     // run client defined data hooks
     await asyncBatch(batch.records, handler, options, event)
 
-    const recordsUpdates = new RecordTranslater<FlatfileRecord>(
-      batch.records
-    ).toXRecords()
+    event.afterAll(async () => {
+      const batch = event.cache.get<FlatfileRecords<any>>('records')
 
-    await event.cache.set('records', async () => recordsUpdates)
+      const recordsUpdates = new RecordTranslater<FlatfileRecord>(
+        batch.records
+      ).toXRecords()
 
-    event.afterAll(async () => {
-      const records = event.cache.get<Records>('records')
       try {
-        return await event.update(records)
+        return await event.update(recordsUpdates)
       } catch (e) {
         console.log(`Error updating records: ${e}`)
       }