Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Merge connection example #22

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat: add Merge connection example #22

merged 3 commits into from
Oct 5, 2023

Conversation

carlbrugger
Copy link
Contributor

@carlbrugger carlbrugger commented Oct 4, 2023 •
edited
Loading

Kitchen sink examples for FlatFilers/flatfile-plugins#250

@carlbrugger carlbrugger mentioned this pull request Oct 4, 2023
Merged
ashleygmulligan2
ashleygmulligan2 suggested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ashleygmulligan2 ashleygmulligan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a readme in here that matches your plugin readme.md. Add a typescript example. Call this folder connect_alpha

ashleygmulligan2
ashleygmulligan2 suggested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ashleygmulligan2 ashleygmulligan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a readme in here that matches your plugin readme.md. Add a typescript example. Call this folder connect_alpha

@carlbrugger carlbrugger marked this pull request as ready for review October 5, 2023 17:02
@carlbrugger carlbrugger merged commit 4f0ae62 into main Oct 5, 2023
1 check passed
@carlbrugger carlbrugger deleted the feat/add-connect-merge branch October 5, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleygmulligan2 ashleygmulligan2 ashleygmulligan2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlbrugger @ashleygmulligan2