Skip to content

Commit

Permalink
Merge pull request #1 from Flared/seb/remove-hack-that-recalculate-he…
Browse files Browse the repository at this point in the history
…ight-for-legend

Remove hack that recalculate height of legend
  • Loading branch information
sebd11 authored Nov 9, 2023
2 parents 1b031c1 + ce893b9 commit afc5939
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 11 deletions.
2 changes: 1 addition & 1 deletion dist/apexcharts.amd.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/apexcharts.common.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/apexcharts.esm.js

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions dist/apexcharts.js
Original file line number Diff line number Diff line change
Expand Up @@ -23899,9 +23899,6 @@
chartInnerDimensions = Math.max(w.globals.radialSize * 2.05, maxHeight);
}
var newHeight = chartInnerDimensions + gl.translateY + legendHeight + offY;
if (gl.dom.elLegendForeign) {
gl.dom.elLegendForeign.setAttribute('height', newHeight);
}

// fix apexcharts/apexcharts.js/issues/3105 (when % is provided in height, it keeps increasing)
if (w.config.chart.height && String(w.config.chart.height).indexOf('%') > 0) return;
Expand Down
2 changes: 1 addition & 1 deletion dist/apexcharts.min.js

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions src/modules/Core.js
Original file line number Diff line number Diff line change
Expand Up @@ -491,10 +491,6 @@ export default class Core {

let newHeight = chartInnerDimensions + gl.translateY + legendHeight + offY

if (gl.dom.elLegendForeign) {
gl.dom.elLegendForeign.setAttribute('height', newHeight)
}

// fix apexcharts/apexcharts.js/issues/3105 (when % is provided in height, it keeps increasing)
if (w.config.chart.height && String(w.config.chart.height).indexOf('%') > 0)
return
Expand Down

0 comments on commit afc5939

Please sign in to comment.