Add Microsoft calendar syncing #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests all pass, need to add new tests Consider refactoring to avoid multiple provider `if` statements
Instead of multiple `if` statements, use Object-Oriented approach
JonFranchi
reviewed
Dec 6, 2022
| }, | ||
| start: event.start, | ||
| end: event.end, | ||
| attendees: GetAttendeeSelf(event, this.address), |
There was a problem hiding this comment.
Does GetAttendeeSelf still work in Microsoft? It was finding a specific attendee object on the attendee array (self) which contained the key:value self: true.
There was a problem hiding this comment.
Ah, thanks for pointing this out - it doesn't look like the payload from MS provides any "self" indicator, but each attendee is a full object:
{
"type": "required",
"status": {
"response": "accepted",
"time": "0001-01-01T00:00:00Z"
},
"emailAddress": {
"name": "Jeremy Scherer",
"address": "[email protected]"
}
},
so maybe a new class function instead of a "static" function since it'll be implementation dependent
Flare576
force-pushed
the
add-microsoft
branch
2 times, most recently
from
0849692 to
d1b770a
Compare
Flare576
force-pushed
the
add-microsoft
branch
from
d1b770a to
300b70a
Compare
Flare576
commented
Feb 15, 2023
| reminderMinutesBeforeStart: 0, | ||
| body: { | ||
| contentType: 'text', | ||
| content: this.obfuscateTo || !INCLUDE_DESC() ? DESC_NOT_COPIED_MSG : event, |
There was a problem hiding this comment.
Suggested change
| content: this.obfuscateTo || !INCLUDE_DESC() ? DESC_NOT_COPIED_MSG : event, | |
| content: this.obfuscateTo || !INCLUDE_DESC() ? DESC_NOT_COPIED_MSG : event.description, |
Flare576
commented
Feb 15, 2023
| useDefault: false, | ||
| overrides: [], // No reminders | ||
| }, | ||
| description: this.obfuscateTo || !INCLUDE_DESC() ? DESC_NOT_COPIED_MSG : event, |
There was a problem hiding this comment.
Suggested change
| description: this.obfuscateTo || !INCLUDE_DESC() ? DESC_NOT_COPIED_MSG : event, | |
| description: this.obfuscateTo || !INCLUDE_DESC() ? DESC_NOT_COPIED_MSG : event.description, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two primary features:
Adding Office365 support required changing the format of CALENDARS_TO_MERGE into an object-based structure to allow the clientID/Secret/Tenant details to be stored. Additionally, parsing the details and formatting events for different APIs made adding some classes (one for each calendar type) make sense as well.
The PR could have been made smaller by adding the obfuscation feature separately, but it would have required changing many of the same parts of code twice, so I opted to roll it into the same effort.
I am noticing that the oAuth access dies after some time right now, and I'm not sure why (I have to re-approve the app); I'll be investigating that, but for now I think this code is ready to review.