Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix flagscale entrypoint train.py and update extra_valid for newest megatron #306

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

zhaoyinglia
Copy link
Collaborator

No description provided.

@zhaoyinglia zhaoyinglia requested a review from a team as a code owner January 6, 2025 04:48
@@ -1141,7 +1134,7 @@ def training_log(loss_dict, total_loss_dict, learning_rate, decoupled_learning_r
total_loss_dict[nan_iters_key] = 0
print_rank_last(log_string)
if not args.auto_tune:
if report_memory_flag and learning_rate > 0.:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this pr remove the learning_rate > 0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cause Megatron-LM removed it, but we didn't in the previous merge-megatron pr.

Copy link
Contributor

@aoyulong aoyulong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aoyulong aoyulong merged commit 0ba8435 into FlagOpen:main Jan 6, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants