-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Update CI image and unit tests #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used by container destruction
phoenixdong
force-pushed
the
CI_update
branch
from
December 11, 2024 04:44
cf8a780
to
6937807
Compare
phoenixdong
force-pushed
the
CI_update
branch
from
December 17, 2024 05:45
7004e4f
to
1fd8d04
Compare
…o Flagscale merged version
…k to Flagscale merged version
…k to Flagscale merged version
phoenixdong
force-pushed
the
CI_update
branch
from
December 17, 2024 11:55
5b7fa1c
to
b402a95
Compare
aoyulong
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI images:
Using nvcr.io/nvidia/pytorch: 24.05-py3 as the base image, the name of the built image is 'flagscale_cicd:v2.0-pytorch-2.5.1-cuda-12.4.131-ngc-24.05'
V2.0 represents a major image update
Pytorch 2.5.1-CUDA-12.4.131-NGC-24.05 represents software and basic image versions
Unit tests :
Run all unit tests, skip/fix errors, overall pass
For megatron unit testing: fixing(know why something went wrong) or skip
For Flagscale unit testing: fixing
Functional tests :
Bug fix :
TODO :
Add vLLM inference testing
Add Dockerfile.ci (using conda)