[CI] Update CI image and unit tests #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoenixdong
changed the title
phoenixdong
changed the title
phoenixdong
changed the title
aoyulong
reviewed
Dec 9, 2024
| @@ -280,6 +281,8 @@ def test_load_distribution(self, parallelization_along_dp, tmp_path_dist_ckpt): | |||
|
|
|||
| assert loaded_state_dict.keys() == state_dict.keys() | |||
|
|
|||
| # The mock function running internally was not called | |||
| @pytest.mark.skipif(os.getenv('flagscale_skip') == '1', reason="flagscale_skip is enabled, skipping test.") | |||
There was a problem hiding this comment.
The environment variable should be in uppercase letters.
…used by container destruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI images：
Using nvcr.io/nvidia/pytorch: 24.05-py3 as the base image, the name of the built image is 'flagscale_cicd:v2.0-pytorch-2.5.1-cuda-12.4.131-ngc-24.05'
V2.0 represents a major image update
Pytorch 2.5.1-CUDA-12.4.131-NGC-24.05 represents software and basic image versions
Unit tests :
Run all unit tests, skip/fix errors, overall pass
For megatron unit testing: repair those that can be repaired, and skip those that cannot be repaired and megatron itself also reports an error
For Flagscale unit testing: fixing
Bug fix :
TODO :
Add vLLM inference testing
Add training tests for Llava onevision