Skip to content

Commit

Permalink
[Fix] no_shared_fs should be under the field runner (#300)
Browse files Browse the repository at this point in the history
“no_shared_fs" should be under the field "runner"

Change
no_shared_fs = config.experiment.get("no_shared_fs", False) 
to 
no_shared_fs = runner_config.get("no_shared_fs", False)
  • Loading branch information
changsci authored Dec 30, 2024
1 parent 3d81a6e commit 96be80f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flagscale/runner/runner_train.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def _get_runner_cmd_train(
rdzv_id = runner_config.get("rdzv_id", "default")
log_dir = runner_config.get("log_dir", logging_config.details_dir)
log_dir = os.path.abspath(log_dir)
no_shared_fs = config.experiment.get("no_shared_fs", False)
no_shared_fs = runner_config.get("no_shared_fs", False)
if no_shared_fs:
log_dir = os.path.join(log_dir, f"host")
else:
Expand Down

0 comments on commit 96be80f

Please sign in to comment.