-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance MM Kernel Performance and Coverage for Specific Input Scenarios #405
Open
kiddyjinjin
wants to merge
23
commits into
FlagOpen:master
Choose a base branch
from
kiddyjinjin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
Performance Optimization
Description
This PR introduces improvements to the matrix multiplication (MM) kernels to address specific scenarios and optimize performance across different input patterns and sizes.
Key Updates:
1. Support Column-Major Input for Matrix B in Tests and Benchmarks
2. Expanded Tuning Configurations for Large-K Scenarios
3. Optimized Kernels for Small M and N Inputs
4. Two-Stage Kernel for Large-K Scenarios
[SPLIT_K, M, N]
matrix.[M, N]
output matrix.Progress
Performance
Large-K Performance with Matrix B as Column-Major
1. Large-K with Matrix B as Column-Major (
float16
)Small M and N Matrix
1. Small M and N (
float16
)1. Small M and N (
float32
)1. Small M and N (
bfloat16
)Base Performance:
Current Performance:
b_row_major
b_column_major