allow HF model download, allow disabling tqdm bars #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also sets a reasonable default of showing the progress bar if more than one batch is processed.
|
it is very useful for disabling the tqdm progress bar👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes a problem where the layerwise reranker classes could not download models from HF because
local_files_only=Truewas set.closes #721
The second commit adds as
progresskeyword argument to all rerankercompute_scoremethods, which allows the caller to activate/disable the tqdm progress bar. Some of these methods previously disabled the progress bar if the number of samples was less than the arbitrary value of 128. Now all methods will deactivate it by default if there is only one batch, but the user can choose to set it on or off regardless by passingprogress=Trueorprogress=False.