support gdr malloc&free #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MC952-arch
reviewed
Dec 23, 2024
| @@ -17,7 +17,7 @@ flagcxResult_t mluAdaptorDeviceMemcpy(void *dst, void *src, size_t size, flagcxM | |||
| if (stream == NULL) { | |||
| DEVCHECK(cnrtMemcpy(dst, src, size, memcpy_type_map[type])); | |||
| } else { | |||
| DEVCHECK(cnrtMemcpyAsync_V3(dst, src, size, stream->base, memcpy_type_map[type])); | |||
| DEVCHECK(cnrtMemcpyAsync_V2(dst, src, size, stream->base, memcpy_type_map[type])); | |||
There was a problem hiding this comment.
这个貌似没有更好的办法，只能锚定cambricon的某个版本，后续更新cambricon docker后再升级接口。
MC952-arch
reviewed
Dec 23, 2024
| @@ -73,12 +73,12 @@ flagcxResult_t mluAdaptorGetVendor(char *vendor) { | |||
| } | |||
|
|
|||
| flagcxResult_t mluAdaptorGdrMemAlloc(void **ptr, size_t size, void *memHandle) { | |||
| // TODO: Implement GDR memory allocation | |||
| DEVCHECK(cnrtMalloc(ptr, size)); | |||
There was a problem hiding this comment.
这里直接用cnrtMalloc就可以了？不需要再进行额外操作？
There was a problem hiding this comment.
参照cuda代码，添加了防呆。mlu申请gdr内存时暂时没有设置属性的函数，因此暂不需要其他其他操作。
MC952-arch
reviewed
Dec 23, 2024
|
|
||
| ifeq ($(strip $(DEVICE_HOME)),) | ||
| ifeq ($(USE_NVIDIA), 1) | ||
| DEVICE_HOME = /usr/local/cuda | ||
| else ifeq ($(USE_ILUVATAR_COREX), 1) | ||
| DEVICE_HOME = /usr/local/corex | ||
| else ifeq ($(USE_CAMBRICON), 1) | ||
| DEVICE_HOME = /torch/neuware_home | ||
| DEVICE_HOME = $(NEUWARE_HOME) |
There was a problem hiding this comment.
NEUWARE_HOME是系统默认环境变量？
There was a problem hiding this comment.
mlu的docker中都默认设置了这个环境变量，不需要用户自己设置。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.