Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-0 - Allow to add additional domains and destroy resources #15

Merged
merged 1 commit into from
Jan 2, 2024
Merged

PLT-0 - Allow to add additional domains and destroy resources #15

merged 1 commit into from
Jan 2, 2024

Conversation

Engerim
Copy link
Member

@Engerim Engerim commented Jan 2, 2024 •
edited
Loading

  • allow additional domains
  • allow to destroy resources

@Engerim Engerim requested a review from a team as a code owner January 2, 2024 12:54
@Engerim Engerim force-pushed the plt-0-allow-oac branch 2 times, most recently from d689b54 to 40b3780 Compare January 2, 2024 12:58
@Engerim
PLT-0 - Allow to add additional domains and destroy resources
85aeb88 
* allow additional domains
* allow to destroy resources
cytopia
cytopia reviewed Jan 2, 2024
View reviewed changes
main.tf

moved {
from = aws_route53_record.this
to = aws_route53_record.this[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being moved into [0] ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because i made the resource to have a count to allow a destruction of it, so it moved to [0] from none

@Engerim Engerim changed the title PLT-0 - Allow to set origin access controls PLT-0 - Allow to add additional domains and destroy resources Jan 2, 2024
@Engerim Engerim merged commit 1ed00ed into master Jan 2, 2024
2 checks passed
@Engerim Engerim deleted the plt-0-allow-oac branch January 2, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cytopia cytopia cytopia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Engerim @cytopia