Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

works around issues with the webdriver spec #92

Merged
merged 3 commits into from
Sep 30, 2024
Merged

works around issues with the webdriver spec #92

merged 3 commits into from
Sep 30, 2024

Conversation

bmarroquin
Copy link
Contributor

@bmarroquin bmarroquin commented Sep 27, 2024 •
edited
Loading

Fixes #91

  • Disables the IntlBackslash key is covered by the non-int one already
  • makes the shifted version of . be >
  • Adds tests to test all type-able English keys

aristotelos
aristotelos requested changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@aristotelos aristotelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great in general, thank you for your contribution! Added some minor comments

src/FlaUI.WebDriver/Keys.cs Outdated Show resolved Hide resolved
src/FlaUI.WebDriver/Keys.cs Outdated Show resolved Hide resolved
src/FlaUI.WebDriver.UITests/ElementTests.cs Outdated Show resolved Hide resolved
src/FlaUI.WebDriver.UITests/ElementTests.cs Outdated Show resolved Hide resolved
src/FlaUI.WebDriver.UITests/ElementTests.cs Outdated Show resolved Hide resolved
@aristotelos aristotelos merged commit e6f50ff into FlaUI:main Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristotelos aristotelos aristotelos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending keys < or > results in |
2 participants
@bmarroquin @aristotelos