Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Customer & Payments sessions, thus enabling one to use the SDK UI kit #9

Draft
wants to merge 80 commits into
base: master
Choose a base branch
from

Conversation

andreibarabas
Copy link

Currently, you need to build the entire UI yourself, but with the support for ephemeral keys, customer and payment sessions, you can now leverage the SDK UI kit available. Read more at Android Basic Integration

@viktorasl - the PR is based upon the other open one #8 so we should probably get that merged first and then rebase it off of it, but just wanted to bring this into discussion.

Currently it works only on Android, but since you are more versatile in iOS dev, maybe you can solve that part?

@andreibarabas
Copy link
Author

hey @lukebrandonfarrell , @viktorasl - what do you guys think? is this something you want in the library?

@lukebrandonfarrell
Copy link

I'd want this in the library for sure. Will be able to have a proper review of this end of week. Let's see what @viktorasl thinks

@viktorasl
Copy link
Member

Um, yeah, we should sort out previous MR and then we'll jump on this one! Anyways, thanks for the contribution!

@andreibarabas
Copy link
Author

Sure guys. I'm already testing it in production, so let me know when you guys finished with the previous one to rebase it and have it merged.

@andreferi3
Copy link

any updates ?

@andreibarabas
Copy link
Author

@andreferi3 - we've been using this PR in production for quite a while now, so while there is no update on the merge, feel free to use it

@rawatnaresh
Copy link

@andreibarabas I'm getting Error: There was an unexpected error -- try again in a few seconds while using this branch. although the master branch is working as expected. also, the types for billingDetails are missing on theconfirmSetup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants