Fixed location property on TypedElementOnSourceNode.cs #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoutkramer
requested changes
Mar 26, 2024
src/Hl7.Fhir.ElementModel.Shared.Tests/TypedElementOnSourceNodeTests.cs
Outdated
Show resolved
Hide resolved
ewoutkramer
requested changes
Mar 26, 2024
| @@ -45,7 +48,7 @@ public TypedElementOnSourceNode(ISourceNode source, string type, IStructureDefin | |||
| throw Error.Format(nameof(type), $"Cannot determine the type of the root element at '{_source.Location}', " + | |||
| $"please supply a type argument."); | |||
| else | |||
| return (rootType, null); | |||
| return (rootType!, null); | |||
There was a problem hiding this comment.
Let's consider this for a bit - for the first time we are kind of lying here, and we're now saying: "in 98% of the cases, this is non-null - so it's not null". But is 98% good enough? Or should we drop de bang and add a #pragma to make it clear we're dodging the nullability warning?
…into feature/location-itypedelement
ewoutkramer
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TypedElementOnSourceNode.Location should now correctly omit choice type suffixes (like in PocoElementNode)
Related issues
Fixes issue #2642
Testing
Added new unit tests testing some edge cases