Add subtract operator for Date and DateTime. #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register FhirPath binary subtract operation for Date and DateTime.
marcovisserFurore
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Hello @almostchristian,
Thank you for your second PR; it's greatly appreciated.
I was surprised to see that the subtraction operation had not been implemented yet, and I'm grateful that you've addressed it.
I only have a few minor naming corrections to suggest during this review.
| @@ -141,35 +141,48 @@ private static bool tryParse(string representation, out Date value) | |||
| return success; | |||
| } | |||
|
|
|||
| public static Date operator -(Date dateValue, Quantity addValue) | |||
There was a problem hiding this comment.
I would suggest naming the quantity here as subtractValue instead of addValue.
| @@ -150,50 +150,63 @@ private static bool tryParse(string representation, out DateTime value) | |||
| return success; | |||
| } | |||
|
|
|||
| public static DateTime operator -(DateTime dateTimeValue, Quantity addValue) | |||
There was a problem hiding this comment.
I would suggest naming the quantity here as subtractValue instead of addValue.
marcovisserFurore
approved these changes
Sep 28, 2023
marcovisserFurore
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Your contribution, @almostchristian, is greatly appreciated. Thank you for your valuable input!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Closes #2599.
Testing
Hl7.FhirPath.R4.Tests.FhirPathEvaluatorTest.TestDateTimeArithmetic
FirelyTeam Checklist