Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide bypass for not-yet-supported attestation formats #71

Merged
merged 10 commits into from
Feb 25, 2024
Merged

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Feb 25, 2024

By default, the library will require any sort of "certain" trust path during credential registration - this is actually slightly stricter than the previous behavior, as Packed formats can result in this path. To compensate (and as a bonus, ease library development), this provides a new flag that can be passed to the registration verification process that permits these uncertain paths to go through.

In effect, if this flag is set, any credential has the security implications of the none format: you really know nothing about it, but authentication still is cryptographically verified. In the common case this means nothing, since (at minimum) Apple's implementation of passkeys uses fmt: none and blocking them is likely undesirable for most people.

Fixes #69.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 83.71%. Comparing base (3de3eb2) to head (9fcec14).

❗ Current head 9fcec14 differs from pull request most recent head 34d766a. Consider uploading reports for the commit 34d766a to get more accurate results

Files Patch % Lines
src/Attestations/AttestationObject.php 27.27% 8 Missing ⚠️
src/Attestations/LibraryUnsupported.php 0.00% 2 Missing ⚠️
src/CreateResponse.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #71      +/-   ##
============================================
- Coverage     84.81%   83.71%   -1.11%     
- Complexity      283      286       +3     
============================================
  Files            28       29       +1     
  Lines           909      909              
============================================
- Hits            771      761      -10     
- Misses          138      148      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed merged commit 158af06 into main Feb 25, 2024
12 checks passed
@Firehed Firehed deleted the trust-path branch February 25, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide escape hatch for currently-unsupported attestation
1 participant