Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support base64url access for challenges; adjust legacy credential format #61

Merged
merged 5 commits into from
Dec 3, 2023

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Dec 3, 2023

This reduces the need for RP servers to use internal methods by directly exposing the challenge as base64url, which is used by the (limited support) native formats as noted in #48 (a tool to produce the entire format will come as well!).

Additionally, this matches up the storage id formats for both credential formats, which as-is would not function as expected (new authorizations would return a v2, and subsequently could fail to find an existing matching v1 format depending on the lookup approach)

Warning

BC BREAK: this changes the storage identifier for the older credential format. This was noted in tests as a pre-1.0 possibility.

Fixes #59

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8922c02) 85.23% compared to head (fb84f46) 85.27%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #61      +/-   ##
============================================
+ Coverage     85.23%   85.27%   +0.03%     
- Complexity      253      256       +3     
============================================
  Files            27       27              
  Lines           813      815       +2     
============================================
+ Hits            693      695       +2     
  Misses          120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed merged commit 2638034 into main Dec 3, 2023
10 checks passed
@Firehed Firehed deleted the id-b64u branch December 3, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve consistency of Base64URL usage
1 participant