Rewrite base structure #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New: Any resolution is now supported, including 4K and custom resolutions. - New: Possibility to change the language of the game itself. - Includes translation for 14 languages (text only). - Includes full translation for German and English (text + all sound files). - New: Possibility to apply a compatibility fix for The Settlers 4 on Windows >=8 systems. - Includes multi-monitor support and border scrolling without any additonal tools. - Fixes the black terrain graphics bug when you scroll over the map. - Note: New versions of the Settlers installer from GOG do already contain a compatibility fix. - Change: Project has moved from Visual Basic to C# including WPF and MVVM. - Change: The UI uses now a dark design. - Improvement: The Readme was extended with useful information about the game. - Improvement: Removed most of hardcoded DLL's with in place binary editing. Not yet ready to be used.
FireEmerald
commented
Nov 26, 2018
|
|
||
| public CabFile(int index, string name) | ||
| { | ||
| if (index < 0) throw new ArgumentNullException(nameof(index)); |
There was a problem hiding this comment.
Not really a ArgumentNullException.
|
|
||
| File.WriteAllBytes(dDrawFile.FullName, Properties.Resources.DDraw); | ||
|
|
||
| _ReportManager.ReportMessage("Compatibility fix applied ... OK"); |
There was a problem hiding this comment.
.ReportMessage() should only be used inside ReportingSink.
| Result texturesChanged = ChangeTextures(installDir, true); | ||
|
|
||
| if (!texturesChanged.Success) | ||
| _ReportManager.ReportMessage(texturesChanged.ErrorMessage); |
There was a problem hiding this comment.
.ReportMessage() should only be used inside ReportingSink.
| if (destinationFile == null) throw new ArgumentNullException(nameof(destinationFile)); | ||
|
|
||
| if (destinationFile.Exists) | ||
| { |
There was a problem hiding this comment.
Code style, remove brackets.
| return new Result(); | ||
| } | ||
|
|
||
| private void RemoveReadOnlyFileAttribute(string fullFilePath) |
There was a problem hiding this comment.
Should maybe moved to external class if used somewhere else.
| var gameSettingsFile = new FileInfo(Path.Combine(installDir.FullName, GAMESETTINGS_RELATIVE_PATH)); | ||
|
|
||
| if (!gameSettingsFile.Exists) | ||
| { |
There was a problem hiding this comment.
Code style, remove brackets.
| if (!(value is bool)) throw new InvalidOperationException($"Passed type is invalid, {nameof(InvertBoolConverter)} requires a {typeof(bool)}."); | ||
|
|
||
| return !(bool) value; | ||
|
|
There was a problem hiding this comment.
Code style, remove empty line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet ready to be used.
Updates #6.