Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDITORIAL] ListCost: convert normative statement into bullet points #654

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

jpradocueva
Copy link
Contributor

This PR is related to issue #606 and converts normative statements into bullet points.

@jpradocueva jpradocueva added the editorial Items that address editorial and minor changes label Nov 21, 2024
@jpradocueva jpradocueva requested a review from a team as a code owner November 21, 2024 13:07
@jpradocueva jpradocueva added this to the v1.2 milestone Nov 21, 2024
@jpradocueva jpradocueva linked an issue Nov 21, 2024 that may be closed by this pull request
@kk09v
Copy link
Contributor

kk09v commented Dec 4, 2024

This change looks good, but I just wanted to note that this definition could use some review:

  • ListUnitPrice is conditional on a price list being published, but ListCost is mandatory and not nullable.
    • There is no guidance for how ListCost should be calculated when ListUnitPrice is not present.
  • The first reference to List Unit Price links to the glossary rather than the column.

@ijurica
Copy link
Contributor

ijurica commented Dec 5, 2024

This change looks good, but I just wanted to note that this definition could use some review:

  • ListUnitPrice is conditional on a price list being published, but ListCost is mandatory and not nullable.

    • There is no guidance for how ListCost should be calculated when ListUnitPrice is not present.
  • The first reference to List Unit Price links to the glossary rather than the column.

Adding a couple of notes:

  • Guidance for how ListCost should be calculated**

    • ListUnitPrice MUST be null when ChargeCategory is "Tax" and I'm not sure if, in case of tax, we can even describe how this should or could be calculated. (there is so much I don’t know about taxes 😃) The question is: should we rephrase this or attempt to describe it, if possible?
    • By the way, we used a similar phrase in Contracted Cost.
  • Link to glossary term

    • The link to the glossary was also used in Contracted Cost. I'm not saying that it was the right decision, but it was intentional 😄. The decision was made to link the glossary term because those unit prices might not always be present.

Overall, I suggest we discuss and address this as part of #557 (copying this comment there).

@jpradocueva
Copy link
Contributor Author

The group agreed to the work in stages. First is to convert the normative statements into bullet points and then enhance the bullet points according to #557. The PR is approved.

@jpradocueva jpradocueva merged commit 8f433b8 into working_draft Dec 6, 2024
2 checks passed
@jpradocueva jpradocueva deleted the editorial-listcost branch December 6, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Items that address editorial and minor changes
Projects
Status: W.I.P
Development

Successfully merging this pull request may close these issues.

[DISCUSSION]: 24.09.27 - Columns – Editorial PRs
4 participants