FOCUS #151: Commitment Discount Category #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First draft for review
rodneyjoyce
requested review from
flanakin,
caseydoran,
flowerinthenight,
chandra-cloudtrakr,
aqu-erp,
joe-ferrero and
jasonkellyAP
added 6 commits
September 9, 2023 16:32
Updated Master List of Dimensions
on Dimensions list
Removed trailing space
Added newline at end
Fixing Trailing spaces
udam-f2
reviewed
Sep 10, 2023
flanakin
reviewed
Sep 13, 2023
Ok, agreed Co-authored-by: Udam Dewaraja <[email protected]>
Noted Co-authored-by: Michael Flanakin <[email protected]>
-Based
CommitmentDiscountId
17 tasks
flanakin
changed the title
flanakin
approved these changes
Sep 22, 2023
udam-f2
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
@rodneyjoyce @flanakin what do we need to do to wrap this up and get checked in?
Just wanted to get maintainers inputs. Will share it with members to review... |
cnharris10
reviewed
Oct 17, 2023
tobrien
approved these changes
Oct 18, 2023
ljadvey
approved these changes
Oct 19, 2023
udam-f2
reviewed
Oct 19, 2023
joshk0
approved these changes
Oct 19, 2023
Co-authored-by: Udam Dewaraja <[email protected]>
yprikhodko
reviewed
Oct 25, 2023
yprikhodko
reviewed
Oct 25, 2023
yprikhodko
reviewed
Oct 25, 2023
added 7 commits
October 30, 2023 11:42
and standardised across 3 files as per feedback
to indicate Normalised column
flanakin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft for review