Switch to ThreadPoolExecutor/ProcessPoolExecutor instead of using spawning processes #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The most significant improvement in the project for the last 6 years! |
Fillll
reviewed
Nov 5, 2022
| random.shuffle(list_of_processes_to_start) | ||
| executor = _create_thread_pool(config) | ||
| executor.map( | ||
| lambda submodule_name: _process_single_entry(submodule_name, config), |
There was a problem hiding this comment.
Or argument by default as suggested above.
There was a problem hiding this comment.
You are right. Changed to the default argument.
reddit2telegram/cron_app.py
Outdated
| def _process_single_entry( | ||
| submodule_name, | ||
| config, | ||
| is_test, |
There was a problem hiding this comment.
Suggested change
| is_test, | |
| is_test=False, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This is an attempt to fix the issue described in #221.
cron_job.pyspawns an uncontrollable number of Python processes, which leads to random OOM errors on servers with small amount of RAM.This PR introduces a mechanism to control the amount of processes or switch to thread-based implementation to save even more memory.