[UXIT-1680] Event Page · Fixup Section Title Pluralization #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mirhamasala
changed the title
|
@CharlyMartin - Tagging for visibility. 🙏🏼 |
mirhamasala
deleted the
mm/event-page-speakers-moderators-fixup-pluralization
branch
CharlyMartin
approved these changes
Oct 29, 2024
@CharlyMartin - Ah, here's a throwback >>. It's difficult to get this right manually. For example, what do you do about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new dependency, updates type definitions, and improves the handling of participant titles in event details. The most important changes include adding the
pluralizelibrary and using it to dynamically format participant titles based on their count. Related to #767Dependency updates:
package.json: Addedpluralizelibrary (^8.0.0) and its type definitions (^0.0.33). [1] [2]Event details and participant title formatting improvements:
src/app/events/[slug]/components/ScheduleSection/EventDetails.tsx: UpdatedParticipantscomponent title from "Moderators" to "Moderator" and "Speakers" to "Speaker". (src/app/events/[slug]/components/ScheduleSection/EventDetails.tsxL32-R35)src/app/events/[slug]/components/ScheduleSection/Participants.tsx: Importedpluralizelibrary and used it to format participant titles based on the count. (src/app/events/[slug]/components/ScheduleSection/Participants.tsxR3-R4, src/app/events/[slug]/components/ScheduleSection/Participants.tsxR13-R19)