Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UXIT-1556 - Cleaning: move files, rename files and update generate page #707

Merged
merged 8 commits into from
Oct 10, 2024
Merged

UXIT-1556 - Cleaning: move files, rename files and update generate page #707

merged 8 commits into from
Oct 10, 2024

Conversation

barbaraperic
Copy link
Collaborator

@barbaraperic barbaraperic commented Oct 9, 2024 •
edited
Loading

📝 Description

This PR includes a series of refactors aimed at improving code readability and organisation.

  • Type: Refactor

🛠️ Key Changes

  • Rename filename covertMarkdowntoBlogPostData to convertMarkdowntoBlogPostData
  • Rename leaderboardTableData to LeaderBoardTableColumns.tsx and move to local components folder
  • Move ctaType and imageType directly into _types
  • Move navigationData and filecoinEcosystemData directly into _data
  • Rename all schema filenames that use camelCase to use PascalCase
  • Ensure "generate:page” stills works as expected

@barbaraperic barbaraperic self-assigned this Oct 9, 2024
@notion-workspace Notion Workspace
Copy link

[FF] Scout Cleaning

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
filecoin-foundation-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 11:04am

@barbaraperic barbaraperic marked this pull request as ready for review October 10, 2024 09:32
@mirhamasala mirhamasala self-requested a review October 10, 2024 11:04
@mirhamasala
Copy link
Collaborator

@barbaraperic - Thank you! 🧼 Let's get this merged as soon as possible to prevent conflicts!

@barbaraperic barbaraperic merged commit 70124b1 into main Oct 10, 2024
5 checks passed
@barbaraperic barbaraperic deleted the bp/cleaning branch October 10, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirhamasala mirhamasala Awaiting requested review from mirhamasala

Assignees

@barbaraperic barbaraperic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barbaraperic @mirhamasala