UXIT-1428 - Headless UI v2 component refactor #701
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Looking good! 🙌🏼 Nit: I would rename everything to include the full name by adding UI so HeadlessUIListboxButton, etc.
I think we can also run npm install @headlessui/react@latest at this point.
Tagging @CharlyMartin for a second look. 🙏🏼
There was a problem hiding this comment.
@barbaraperic I think we can remove most aria labels as they are managed by Headless UI now. Also, in some instances, we should import their type definition to be closer to reality.
Let me know what you think :)
Thanks!
As a more general comment, we might want to find a way to use FormListbox here. The implementation of both components is very similar, but that's probably for another PR!
CharlyMartin
force-pushed
the
bp/update-headless-ui-components
branch
from
c159454 to
a5832bd
Compare
|
@mirhamasala I got rid of the |
There was a problem hiding this comment.
@barbaraperic @CharlyMartin - Love it! So much cleaner! ❤️ LGTM!
* refactor headless ui component v2 * replace headless with headlessUI and fix active to focus * remove aria label and implement data selectors * upgrade headless version and remove aria lables * fixup! refactor headless ui component v2 * Remove Transition component from Popover --------- Co-authored-by: Mirha Masala <[email protected]> Co-authored-by: Charly MARTIN <[email protected]>
📝 Description
The V2 Headless UI components no longer use the <Parent.Child> component pattern, and rely on a different props API.
🧪 How to Test
Check the following and see if everything works as intended (there should be no changes):
🔖 Resources