[UXIT-1415] Refactor Dynamic Images #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mirhamasala
force-pushed
the
mm/refactor-dynamic-images
branch
from
4ffd7d3 to
0742d5c
Compare
mirhamasala
force-pushed
the
mm/refactor-dynamic-images
branch
from
8c38e10 to
ab9a05f
Compare
|
Reviewed live with @CharlyMartin & @barbaraperic - Thank you. 🙌🏼❤️🙌🏼 |
1 task
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request focuses on replacing the
DynamicImageandStaticImagecomponents with thenext/imagecomponent to simplify image handling across the codebase. The most important changes include updating various components to usenext/image, removing the obsoleteDynamicImageandStaticImagecomponents, and adjusting image properties accordingly.🛠️ Key Changes
Image Handling Updates:
src/app/_components/ArticleHeader.tsx: ReplacedDynamicImagewithnext/imageand updated image properties to handle fallback scenarios. [1] [2]src/app/_components/Card.tsx: Updated theCardcomponent to usenext/imageand adjusted image properties for better handling of dynamic and static images. [1] [2]src/app/_components/PageHeader.tsx: ReplacedDynamicImageandStaticImagewithnext/image, and refactored thePageHeader.Imagecomponent for simplified image handling. [1] [2] [3] [4] [5]Component Removals:
src/app/_components/DynamicImage.tsx: Removed theDynamicImagecomponent as it is no longer needed.src/app/_components/StaticImage.tsx: Removed theStaticImagecomponent as it is no longer needed.Other Updates:
src/app/_components/MarkdownContent.tsx: ReplacedDynamicImagewithnext/imagefor rendering markdown images. [1] [2] [3]StaticImagePropsto point to the new location insharedProps/imageType. [1] [2]These changes help to streamline image handling, reduce redundancy, and improve maintainability across the project.
📌 To-Do Before Merging
Cardwhen no image is provided (See/aboutreports vs. Fallbacks forFeaturedEcosystemProjects)MarkdownContent