UXIT-1555 - Run linters on PRs #689
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
This is a very broad approach, as it includes all branches, even those that may not require linting or testing, such as temporary, experimental, or draft branches. While it ensures that every pull request gets coverage, it might result in unnecessary workflow runs, potentially wasting resources and increasing build times for branches we may not care about.
What if we did something more targeted, like the example below? This would limit the workflow to main and any branches under cms/* or ecosystem-submission/*, ensuring we focus on the branches that matter most right now:
on:
push:
branches:
- main
- cms/*
- ecosystem-submission/*
pull_request:
branches:
- main
- cms/*
- ecosystem-submission/*
This way, we only trigger the workflow for relevant branches, avoiding excess runs while still ensuring coverage for critical parts of the project.
📝 Description
Modify
lint.ymlto run on every open pull request.🧪 How to Test
Can't test locally, so once it's merged, we can test with a PR coming from the CMS.
🔖 Resources