Skip to content

Commit

Permalink
Migrate to shared-actions v2
Browse files Browse the repository at this point in the history
> [!IMPORTANT]
> **Please thoroughly review this PR before approving and merging**
> This migration is complicated and may require some manual changes. Below we will call out breaking changes and other important notes.

This PR moves all workflows to the new shared-actions v2. Please check out the following docs for more information on this migration:
- [Migration Guide](https://docs.devops.figure.com/shared-actions/v2-migration-guide)
- [Migration Changes](https://docs.devops.figure.com/shared-actions/v2-migration-changes)

Please reach out to [#github-actions-help](https://figure-group.slack.com/archives/C044W9BRAVD) with any and all questions, someone from devops or core tech will be able to help.

---

### Notes
- Once you've merged in this PR and are running `v2` actions it is worth watching your workflows for warnings about inputs that are no longer used. We are able to handle a lot of replacements automatically, but we err on the side of caution to avoid breaking other github actions that we don't own. These warnings won't ever break your builds, but it is good practice to keep them clean.
- Some other common upgrades are also done in this PR, like updating other `actions/` to their latest versions.

🤖🪄 This PR was automatically created by a magic script.
  • Loading branch information
ahatzz11 committed Sep 10, 2024
1 parent 92d7504 commit a41e34c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
uses: gradle/actions/setup-gradle@v3
with:
cache-read-only: ${{ github.ref != 'refs/heads/main' }}
gradle-home-cache-cleanup: true
cache-cleanup: true
gradle-home-cache-includes: |
caches
notifications
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Release
on:
workflow_dispatch:
inputs:
versionModifier:
version-modifier:
description: "Version Modifier"
default: "minor"
type: choice
Expand All @@ -12,7 +12,7 @@ on:
- "patch"
- "minor"
- "major"
skipPublishing:
skip-publishing:
description: "Skip artifact publishing"
required: false
type: boolean
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:
echo "githubReleaseCommand=githubRelease" >> $GITHUB_OUTPUT
fi
env:
SKIP_PUBLISH: ${{ github.event.inputs.skipPublishing }}
SKIP_PUBLISH: ${{ github.event.inputs.skip-publishing }}

- name: Install gpg secret key
run: |
Expand All @@ -68,7 +68,7 @@ jobs:
uses: gradle/actions/setup-gradle@v3
with:
cache-read-only: ${{ github.ref != 'refs/heads/main' }}
gradle-home-cache-cleanup: true
cache-cleanup: true
gradle-home-cache-includes: |
caches
notifications
Expand All @@ -78,7 +78,7 @@ jobs:
- name: Build and Release Main
run: |
./gradlew \
-Psemver.modifier=${{ github.event.inputs.versionModifier }} \
-Psemver.modifier=${{ github.event.inputs.version-modifier }} \
build ${{ steps.build_parameters.outputs.publishCommand }} \
${{ steps.build_parameters.outputs.githubReleaseCommand }} \
-Psigning.keyId=${{ secrets.OSSRH_GPG_SECRET_KEY_ID }} \
Expand Down

0 comments on commit a41e34c

Please sign in to comment.