Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vite integration to create a project bundle js and reduce the number of calls #259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

p4535992
Copy link
Contributor

@p4535992 p4535992 commented Nov 1, 2023

Added vite integration to create a project bundle js and reduce the number of calls

@p4535992
Copy link
Contributor Author

Re-uploaded some stuff i add some util to export the source of hte packs and some better vite build utility.

@Rughalt
Copy link
Collaborator

Rughalt commented May 13, 2024

I would wait with that until we merge the release script - and update the script with vite build once we know the basic process based of NPM works. Wtyd @p4535992 ?

@p4535992
Copy link
Contributor Author

p4535992 commented May 13, 2024

Sorry what does “Wtyd” mean ! In the past I used it in game for the phrase “Welcome to your death” XD.

No rush ... by the way i just see a alternative solution with npx and rollup for this on the black flags system, maybe is even better ?

@Abourass
Copy link

Abourass commented Jul 2, 2024

Sorry what does “Wtyd” mean ! In the past I used it in game for the phrase “Welcome to your death” XD.

No rush ... by the way i just see a alternative solution with npx and rollup for this on the black flags system, maybe is even better ?

I think they just misspelled "WDYT" (What do you think?)

I think Vite brings a better level of support. It uses rollup under the hood but has not only an easier DX for setting up ways to make the bundle more efficient, but also has they added bonus of being easily integrated with Vitest for unit testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants