Add an optional progress bar to Sequence #79
+64
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpigeon
force-pushed
the
dano-progress-bar
branch
from
adc9e64
to
81a3fb5
Compare
|
Oh, apologies for the force-push! 😬 |
FelixHenninger
force-pushed
the
master
branch
2 times, most recently
from
00b2493
to
6eee692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be nice for the library to have an easy-to-use progress bar like jspsych has. I went ahead and made same changes to the Sequence in class in order to achieve that in this PR.
I'm not sure if adding this directly to Sequence is this best idea as this will break if the user tries to nest progress bars. Maybe it could be added to the global Lab.js 'engine'?
Also, I was pretty shocked to put this whole thing together and then find some CSS styles for a progress bar! I didn't see anywhere in the library where these would be applied, so I'm curious what the story is.
Cheers, and let me know what I can do to tidy this up.