Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.9 and 3.10 support #969

Merged
merged 14 commits into from
Nov 17, 2024
4 changes: 2 additions & 2 deletions .github/workflows/freeze-for-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ jobs:
repository: ${{ github.event.pull_request.head.repo.full_name }}
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
if: github.event.action != 'closed'
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
if: github.event.action != 'closed'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: Build project
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/py-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13-dev"]
python-version: ["3.11", "3.12", "3.13"]

runs-on: ${{ matrix.os }}

Expand Down Expand Up @@ -55,10 +55,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/reformat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: Install prerequisites
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/resync-piped.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/type-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update-licence.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/upgrade-locks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/verify-locks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/verify-types.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
with:
submodules: "true"

- name: Set up Python 3.9
- name: Set up Python 3.11
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: "3.9"
python-version: "3.11"

- name: install prerequisites
run: |
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Moved away from using `typing.runtime_checkable` as this is unreliable in
newer Python versions.

### Removed
- Support for Python 3.9 and 3.10.

## [2.17.6] - 2024-10-07
### Changed
- Support Python 3.13.
Expand Down
11 changes: 5 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,11 @@ and should also use styles which are specific to [pdoc](https://pdoc.dev/docs/pd
A few examples of pdoc style would be:

* Links: Unlike sphinx, regardless of whether you're linking to a module, class, function or variable the link will
always be in the style of `` `link.to.thing` `` with no type information included and relative links being supported
for types in the current module (e.g. `` `Class.attribute` ``.
always be in the style of `` [link.to.thing][] `` with no type information included.
* Documenting fluent methods: The return type for fluent methods should be given as `Self` with the description for it
following the lines of something like "the {x} instance to enable chained calls".
* Documented types (such as for parameters and return types) which are unions should be documented using `|` style
and `T | None`/`T | hikari.UndefinedType` are preferred over `typing.Optional[T]`/`hikari.UndefinedOr[T]`
* Union types should be annotated in code and documentation using `|` style and `T | None`/`T | hikari.UndefinedType`
are preferred over `T | None`/`hikari.UndefinedOr[T]`

### CHANGELOG.md

Expand All @@ -65,8 +64,8 @@ good references for how projects should be type-hinted to be `type-complete`.
**NOTES**

* This project deviates from the common convention of importing types from the typing module and instead
imports the typing module itself to use generics and types in it like `typing.Union` and `typing.Optional`.
* Since this project supports python 3.9+, the `typing` types which were deprecated by
imports the typing module itself to use generics and types in it like `typing.Annotated`.
* Since this project supports python 3.11+, the `typing` types which were deprecated by
[PEP 585](https://www.python.org/dev/peps/pep-0585/) should be avoided in favour of their `collections.abc`,
builtin, `re` and `contextlib` equivalents.
* The standard approach for using `collections.abc` types within this project is to `import collections.abc as collections`.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ A flexible command framework designed to extend Hikari.

# Installation

You can install Tanjun from PyPI using the following command in any Python 3.9 or above environment.
You can install Tanjun from PyPI using the following command in any Python 3.11 or above environment.

```
python -m pip install -U hikari-tanjun
Expand Down
Loading
Loading