-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM64] Animations Rewrite/Rework #467
base: main
Are you sure you want to change the base?
Conversation
import c animations actually fucking work, i worship lila from now on, W Lila |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Animation I/O works from C to Binary and the false bounds detection works
You mention this is based on other PRs, so are these other PRs to be merged first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. Been using it for DMA animation exporting with a custom Mario rig. Nothing else in Fast64 seems broken. Been using for a few weeks now.
Ideally, obviously no pressure since the smart includes pr is niche, i just incorporated it for the simple actor include write function (oh and the useful functions for the table update function!) |
Also worth mentioning that I could always remove non animation data from the actor presets until we actually use them, I just thought scut would benifit from them in her importer pr #198 |
Wouldn't it be funny if this was approved, just like, instantly
Based on prs: #449 , #393, #450
Fully rewriten animation exporter and importer, with some code I'm proud of and some code I probably kept from a year ago (be harsh as needed)
anim_test_impor_allt_script.py for testing all import presets
TODO (up for review because code is "done" (as in if I keep trying to find issues on my own for the next months I'll cry)):