Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM64] Fix SM64 binary geolayout exports #423

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Aug 15, 2024

Don't pass in dl reference when not an object empty (need confirmation this is fine)
Update size and export binary functions for transform nodes
Check for export tag in material binary saves (fixes bleed exporting unused data)

There seems to be something wrong with reverts still, will investigate
@Lilaa3 Lilaa3 marked this pull request as draft August 15, 2024 18:07
@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 15, 2024

There seems to be something wrong with reverts still, will investigate before actually having up to review

@Lilaa3 Lilaa3 force-pushed the fix-binary-geolayouts branch from d5e18ea to d37ce93 Compare August 15, 2024 18:20
@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 15, 2024

Last commit accidentaly fixed an issue with bleed in binary!

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 15, 2024

It turns out my last issue was just from world defaults being wonky in the file I was testing, everything is fixed sorry for the wait

@Lilaa3 Lilaa3 marked this pull request as ready for review August 15, 2024 20:14
@SonicTheHedgeHog64
Copy link
Contributor

LET'S FUCKING GO

@Lilaa3 Lilaa3 added bug Something isn't working sm64 Has to do with the Super Mario 64 side f3d Has to do with the "f3d" code common to all games labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working f3d Has to do with the "f3d" code common to all games sm64 Has to do with the Super Mario 64 side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants