Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM64/F3D] Area fog improvements #378

Merged
merged 7 commits into from
Dec 28, 2024
Merged

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Jul 10, 2024

Area fog is now a toggle in the area root
Renamed the text for global fog to area fog
Materials now by default show color and position if set fog is on, then in sm64 mode, if they are parented to an area that sets fog the option for area fog shows up with the area name in the text, if it's on a disabled column with the area's fog properties will also show
image
image
And now the toggle for global fog will not show in oot or homebrew!
image

Area fog is now a toggle in the area root
Renamed the text for global fog to area fog
Materials now by default show color and position if set fog is on, then in sm64 mode, if they are parented to an area that sets fog the option for area fog shows up with the area name in the text, if it's on a disabled column with the area's fog properties will also show
@Lilaa3 Lilaa3 added sm64 Has to do with the Super Mario 64 side f3d Has to do with the "f3d" code common to all games labels Jul 10, 2024
@Lilaa3 Lilaa3 mentioned this pull request Jul 25, 2024
7 tasks
@jesusyoshi54
Copy link
Collaborator

image
The area fog settings are a bit weird. First they use floats while the material fog uses ints. They should match. Second you say "Set Area Fog" in the hint text but the property box is "Set Fog Settings".
I think the message itself is too wordy and could be shorter. Just say something to the effect of, "Fog properties will be applied to all materials with fog enabled that use area fog"

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 5, 2024

The area fog settings are a bit weird. First they use floats while the material fog uses ints. They should match.

Can´t do that without a prop upgrade, using step=100 makes s a fake int and doesn´t require any upgrades so I'm gonna commit that for now, if you think it's worth it to do this properly do say it.

Second you say "Set Area Fog" in the hint text but the property box is "Set Fog Settings". I think the message itself is too wordy and could be shorter. Just say something to the effect of, "Fog properties will be applied to all materials with fog enabled that use area fog"

I tried making the description shorter, but one of the main things I was trying to change was the whole "global" description which honestly was very missleading

Copy link
Collaborator

@jesusyoshi54 jesusyoshi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@jesusyoshi54
Copy link
Collaborator

I made a PR to this branch for conflict, check it out

@jesusyoshi54 jesusyoshi54 added the merge soon Will be merged in a few days at most if nothing else comes up label Dec 22, 2024
@Lilaa3 Lilaa3 merged commit f0ff40c into Fast-64:main Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f3d Has to do with the "f3d" code common to all games merge soon Will be merged in a few days at most if nothing else comes up sm64 Has to do with the Super Mario 64 side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants