Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add properties structure organization #985

Closed

Conversation

richard190m
Copy link
Contributor

@richard190m richard190m commented Feb 7, 2024

Description

Dependencies

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The code is commented, particularly in hard-to-understand areas
  • The labels and/or milestones were added

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@github-actions github-actions bot added type: feature New feature 📦 react Relative to the `@farfetch/blackout-react` package 📦 redux Relative to the `@farfetch/blackout-redux` package and removed type: feature New feature 📦 redux Relative to the `@farfetch/blackout-redux` package labels Feb 7, 2024
feat(react): add properties on structure data organization

Revert "fix(react|redux): commerce pages in ssr not working"

This reverts commit 7bd944a.
@richard190m richard190m force-pushed the feat/add-properties-sctructure-organization branch from 6ee6a64 to 525a58b Compare February 7, 2024 18:45
@github-actions github-actions bot added type: feature New feature and removed type: feature New feature labels Feb 7, 2024
*
* @example
* ```
* const potencialActioin = schemaPotentialAction(searchTitle, urlTemplate, metadata);
Copy link

@boliveira boliveira Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* const potencialActioin = schemaPotentialAction(searchTitle, urlTemplate, metadata);
* const potentialAction = schemaPotentialAction(searchTitle, urlTemplate, metadata);

@boliveira boliveira changed the title feat(react): add properties sctructure organization feat(react): add properties structure organization Feb 9, 2024
@boliveira boliveira added this to the dev-main-13-02-24 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 react Relative to the `@farfetch/blackout-react` package type: feature New feature
Development

Successfully merging this pull request may close these issues.

2 participants