Removing extra classes #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g during rendering
|
This PR is blocked by the release of Gymnasium 1.0 |
|
Damn that is lot of code your able to remove |
reginald-mclean
merged commit 3fa2c78
into
Farama-Foundation:master
3 of 5 checks passed
|
Does this work for gymnasium equals 1.0.0a1? |
|
@Kallinteris-Andreas yeah, I created them with the changes made with 1.0.0a1 in mind. There's some removals of extra code, but the PR also aligns each env with the mujoco_env in 1.0.0a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to move the task creation mechanism from MW into each class and these extra classes are a leftover artifact of that.