Fixes and updating version number #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rtimms There are a lot of experimentation commits in here, so we should definitely squash this PR |
kratman
commented
Dec 20, 2024
Comment on lines
-101
to
-111
| # Delete | ||
| tmp.close() | ||
| Path(tmp.name).unlink(missing_ok=True) | ||
| if module.__cached__: | ||
| cached_file = Path(module.__cached__) | ||
| cached_path = cached_file.parent | ||
| cached_file.unlink(missing_ok=True) | ||
| if not any(cached_path.iterdir()): | ||
| cached_path.rmdir() | ||
|
|
||
| # return the new function object |
There was a problem hiding this comment.
This was causing failures due to cached files not being found. It did not seem necessary
| @@ -26,13 +31,13 @@ def parse_bpx_obj(bpx: dict, v_tol: float = 0.001) -> BPX: | |||
| return BPX.model_validate(bpx) | |||
|
|
|||
|
|
|||
| def parse_bpx_file(filename: str, v_tol: float = 0.001) -> BPX: | |||
| def parse_bpx_file(filename: str | Path, v_tol: float = 0.001) -> BPX: | |||
There was a problem hiding this comment.
This makes the file name more flexible
|
|
||
| bpx = "" | ||
| if filename.endswith((".yml", ".yaml")): | ||
| if str(filename).endswith((".yml", ".yaml")): |
There was a problem hiding this comment.
Related to the path check
kratman
added a commit
that referenced
this pull request
Dec 20, 2024
Updating the changelog to match #81
rtimms
approved these changes
Dec 20, 2024
rtimms
pushed a commit
that referenced
this pull request
Dec 20, 2024
Updating the changelog to match #81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
bpx<0.5.0if required.copy.copy()tocopy.deepcopy()as an extra layer of safety since all of the tests interact with the same dictionary