-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloudfront Support #2
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this feels like a "necessary evil" type of implementation.
In an ideal world, this would be a single interface for the reroute pipeline with specific implementations when the origin is an S3 Bucket, Cloudfront hosted objects, or something else entirely.
It would also be good to add some testing to this, somehow. Depending on how Jest works with mocking. |
… and regression tests
No description provided.