Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloudfront Support #2

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Falpangaea
Copy link
Owner

No description provided.

Copy link

@masteinhauser masteinhauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this feels like a "necessary evil" type of implementation.

In an ideal world, this would be a single interface for the reroute pipeline with specific implementations when the origin is an S3 Bucket, Cloudfront hosted objects, or something else entirely.

src/reroute.js Outdated Show resolved Hide resolved
src/reroute.js Outdated Show resolved Hide resolved
@masteinhauser
Copy link

It would also be good to add some testing to this, somehow. Depending on how Jest works with mocking.

@Falpangaea Falpangaea self-assigned this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants