Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to have click toggle drawing instead of dragging #735

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

vgskye
Copy link
Contributor

@vgskye vgskye commented Aug 23, 2024

closes #357. confirmed working on fabric, forge should probably work

@vgskye
Copy link
Contributor Author

vgskye commented Aug 23, 2024

tested and working on forge as well

@object-Object
Copy link
Member

We should probably also add a localization to the lang file for this cloth config entry. see here:

client: {
ctrlTogglesOffStrokeOrder: {
"": "Ctrl Toggles Off Stroke Order",
"@Tooltip": "Whether the ctrl key will instead turn *off* the color gradient on patterns",
},
invertSpellbookScrollDirection: {
"": "Invert Spellbook Scroll Direction",
"@Tooltip": "Whether scrolling up (as opposed to down) will increase the page index of the spellbook, and vice versa",
},
invertAbacusScrollDirection: {
"": "Invert Abacus Scroll Direction",
"@Tooltip": "Whether scrolling up (as opposed to down) will increase the page index of the abacus, and vice versa",
},
gridSnapThreshold: {
"": "Grid Snap Threshold",
"@Tooltip": "When using a staff, the distance from one dot you have to go to snap to the next dot, where 0.5 means 50% of the way (0.5-1)",
},
},

@vgskye
Copy link
Contributor Author

vgskye commented Aug 24, 2024

We should probably also add a localization to the lang file for this cloth config entry.

I feel like this can be batched with #729?

@object-Object
Copy link
Member

i don't see any reason to? just because other options didn't get localizations doesn't mean we should continue not adding them for new ones. imo the localizations for a given feature should be added in the PR where the feature itself is added when possible.

@vgskye
Copy link
Contributor Author

vgskye commented Aug 24, 2024

fair, lemme add that after a rebase

@vgskye vgskye force-pushed the toggledraw branch 5 times, most recently from b7fdf7b to d605087 Compare August 28, 2024 03:12
@gamma-delta
Copy link
Collaborator

If it's tested and confirmed working it LGTM.

@gamma-delta gamma-delta self-requested a review September 6, 2024 16:06
Copy link
Collaborator

@gamma-delta gamma-delta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM. Please rebase and I'll merge it.

@vgskye
Copy link
Contributor Author

vgskye commented Sep 6, 2024

why the fuck is hexdoc failing I didn't even touch anything doc-related

@gamma-delta
Copy link
Collaborator

The hexdoc issue was fixed hexdoc-dev/hexdoc@9e1025c so hopefully that should pass now

@gamma-delta gamma-delta closed this Sep 9, 2024
@gamma-delta gamma-delta reopened this Sep 9, 2024
@gamma-delta
Copy link
Collaborator

Oh my god Github

@gamma-delta
Copy link
Collaborator

We should probably document this at some point but again not something I care to block on.

@gamma-delta gamma-delta merged commit cdfe88c into FallingColors:main Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
3 participants