-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to have click toggle drawing instead of dragging #735
Conversation
tested and working on forge as well |
We should probably also add a localization to the lang file for this cloth config entry. see here: HexMod/Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5 Lines 286 to 303 in f3f9d07
|
I feel like this can be batched with #729? |
i don't see any reason to? just because other options didn't get localizations doesn't mean we should continue not adding them for new ones. imo the localizations for a given feature should be added in the PR where the feature itself is added when possible. |
fair, lemme add that after a rebase |
b7fdf7b
to
d605087
Compare
If it's tested and confirmed working it LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, LGTM. Please rebase and I'll merge it.
why the fuck is hexdoc failing I didn't even touch anything doc-related |
The hexdoc issue was fixed hexdoc-dev/hexdoc@9e1025c so hopefully that should pass now |
Oh my god Github |
We should probably document this at some point but again not something I care to block on. |
closes #357. confirmed working on fabric, forge should probably work